Applying mods from custom/private registries

andros705 · 21 July 2020 19:11

Hi, I am interested in using the s6-overlay base layer for my images, specifically the lsiobase/alpine:3.12 layer. I have a few mods that I would like to use but I don’t want to push them into a public docker repository, I have a private repo managed by GitLab and I would like s6 to use mods from this repo.

I tried adding an environment variable like this to the docker-compose.yml but it does not work:
DOCKER_MODS=r.c4.mars.myidea.app:5000/container/mods:php-7.2-jit
All I am getting is:
dash_1 | [mod-init] Attempting to run Docker Modification Logic
dash_1 | [mod-init] Applying r.c4.mars.myidea.app:5000/container/mods:php-7.2-jit files to container
dash_1 | tar: invalid magic
dash_1 | tar: short read

After looking at the script located in the container nano /docker-mods I found that the the dockerhub repository is hardcoded.

I guess the only way would be to rebuild the base layer, but I also wanted to use other linuxserver images and having 2 layers is a waste of space.
Not like I don’t have this space, I am just very pedantic.

I am looking for opinions, could we add the support for custom/private repositories to the official s6 layer?

TheLamer · 21 July 2020 19:46

The logic has no authentication methodology, and it exists solely to let people share their mods hosted on dockerhub:

github.com

linuxserver/docker-baseimage-alpine/blob/master/root/docker-mods

#!/usr/bin/with-contenv bash

# Exit if mods is not set
if [ -z ${DOCKER_MODS+x} ]; then
  exit 0
fi

# Check for curl
if [ ! -f /usr/bin/curl ]; then
  echo "[mod-init] Curl was not found on this system for Docker mods installing"
  if [ -f /usr/bin/apt ]; then
    ## Ubuntu
    apt-get update
    apt-get install --no-install-recommends -y \
      curl
  elif [ -f /sbin/apk ]; then
    # Alpine
    apk add --no-cache \
      curl
  fi

This file has been truncated. show original

Feel free to modify it to suit your needs, but we will likely not be adding that kind of functionality given the core premise.