[LazyLibrarian] SSL changes break Goodreads Sync

Please see the relevant FAQ entry: FAQ - LazyLibrarian Documentation

Not sure exactly when it started (was sometime in the last 2-3 weeks), the Goodreads sync in the LazyLibrarian container broke. The error is below, which seems to track with the fact that Goodreads still uses TLS 1.0 per the FAQ. It was definitely working a month ago, so maybe an update to the packages within the container removed support for TLS 1.0. Any chance this can be reverted as Goodreads Sync is a major part of the LazyLibrarian workflow?

EDIT: Possible commit that caused the issue as it mentions changes to certificates - Bot Updating Package Versions · linuxserver/docker-lazylibrarian@86cdc09 · GitHub

Error in client.request: SSLError Traceback (most recent call last): File “/app/lazylibrarian/lazylibrarian/grsync.py”, line 377, in getUserId response, content = client.request(’%s/api/auth_user’ % lazylibrarian.CONFIG[‘GR_URL’], ‘GET’) File “/app/lazylibrarian/lib/oauth2/init.py”, line 630, in request connection_type=connection_type) File “/app/lazylibrarian/lib3/httplib2/init.py”, line 1322, in request (response, content) = self._request(conn, authority, uri, request_uri, method, body, headers, redirections, cachekey) File “/app/lazylibrarian/lib3/httplib2/init.py”, line 1072, in _request (response, content) = self._conn_request(conn, request_uri, method, body, headers) File “/app/lazylibrarian/lib3/httplib2/init.py”, line 995, in _conn_request conn.connect() File “/usr/lib/python3.6/http/client.py”, line 1442, in connect server_hostname=server_hostname) File “/usr/lib/python3.6/ssl.py”, line 407, in wrap_socket _context=self, _session=session) File “/usr/lib/python3.6/ssl.py”, line 817, in init self.do_handshake() File “/usr/lib/python3.6/ssl.py”, line 1077, in do_handshake self._sslobj.do_handshake() File “/usr/lib/python3.6/ssl.py”, line 689, in do_handshake self._sslobj.do_handshake() ssl.SSLError: [SSL: TLSV1_ALERT_PROTOCOL_VERSION] tlsv1 alert protocol version (_ssl.c:852)

After checking the changes in the upstream project, I noticed there was a typo in the Goodreads URL that was causing the SSL error. The FAQ misled me. This request can be closed as I have submitted a request upstream to fix it.

1 Like